-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix apache configuration documentation #16599
Conversation
Review Checklist
|
@dbu Since this is a bugfix, could you please rebase the PR to 11.1? Thanks |
we need to check for the file in the document root. `%{REQUEST_FILENAME}` does not include the document root
@dbu were you using the config in the context of a |
uh, that might explain it 🙈 i use it in the vhost configuration. i have not done much apache in the last decade, but back in the days |
@dbu Yeah, I guess that's the reason then 😊 |
Quality Gate passedIssues Measures |
anyone in? |
Keeping it as it as for now for 2 reasons:
Using the config in a different context probably needs some more adaptions anyway 🤔 Thanks anyway for your PR. |
Please make sure your PR complies with all of the following points:
doc/
11.1
(see Readme.md for the list of supported versions)Changes in this pull request
I tried the setup instructions but did not get static files to be served. Not sure if the original configuration would be the correct one for some versions of Apache (its been quite a while since i had to use it), but with my 2.4.57, the REQUEST_FILENAME is only the path and we need to prepend the DOCUMENT_ROOT